Add backticks to the gramar #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokensound77
approved these changes
Apr 21, 2020
aleksmaus
approved these changes
Apr 23, 2020
| parse_to("`foo.bar.baz`", ["foo.bar.baz"]) | ||
| parse_to("`foo`.`bar-baz`", ["foo", "bar-baz"]) | ||
| parse_to("`foo`.`bar-baz`", ["foo", "bar-baz"]) | ||
| parse_to("`💩`", ["💩"]) |
tests/test_parser.py
Outdated
| parse_to("`foo bar baz`", ["foo bar baz"]) | ||
| parse_to("`foo.bar.baz`", ["foo.bar.baz"]) | ||
| parse_to("`foo`.`bar-baz`", ["foo", "bar-baz"]) | ||
| parse_to("`foo`.`bar-baz`", ["foo", "bar-baz"]) |
There was a problem hiding this comment.
two lines above are the same. did you mean something else for the second one?
rw-access
added a commit
that referenced
this pull request
May 18, 2020
* Add backtick support and tests * Add engine tests for backtick * Add note to changelog * Add additional backtick test * Unduplicate backtick test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Relates to #15
Closes #19
Details
Fairly straightforward. Added `backtick` support to the grammar and parser.
Validated that the engine is still working as expected.